H5Part development and discussion

[John Biddiscombe <biddisco AT cscs.ch>]

I just noticed that I sent this only to Achim and not the list, so I'll 
just forward it for reference.

> 1. As mentioned above, I type-cast with (struct ...*) and did not need 
> the typedef's.
>   
fine.
> 2. I renamed "_errno" to "_h5part_errno". With "_h5errno" we might get 
> conflicts with HDF5.
>   
fine
> 3. I did not apply the patch
>
> +#ifdef _WIN32
> +  typedef int     errno_t;
> +#else
> +  typedef int64_t errno_t;
> +#endif
>
> Why do we need this?
>   
I think I forgot to remove it after we removed all the other _errno 
stuff - we should not need it now.
> 4. I used the macro "WIN32" without underscore. I'm unsure whether 
> this is the right one. In your patch both "WIN32" and "_WIN32" are 
> used.
>   
By default, everyone uses WIN32, internally the compiler usually defines 
_WIN32 - and then some header like windows.h will define WIN32 if it 
finds _WIN32. You made the correct choice.
NB. In H5PartTypes.h you have written typdef instead of typedef in the 
WIN32 section

Thank you very much indeed. I have now updated my code and am building 
my modules direct from the H5Part source which is nice - I tested the 
latest reveiosn and it built fine on win32 and gcc for me. Finally I can 
work direct from your repository instead of my own local copy. I shall 
send a few more patches for other small issues now.
> Achim
>   
JB

--
John Biddiscombe,                            email:biddisco @ cscs.ch
http://www.cscs.ch/about/BJohn.php
CSCS, Swiss National Supercomputing Centre  | Tel:  +41 (91) 610.82.07
Via Cantonale, 6928 Manno, Switzerland      | Fax:  +41 (91) 610.82.82




--
John Biddiscombe,                            email:biddisco @ cscs.ch
http://www.cscs.ch/about/BJohn.php
CSCS, Swiss National Supercomputing Centre  | Tel:  +41 (91) 610.82.07
Via Cantonale, 6928 Manno, Switzerland      | Fax:  +41 (91) 610.82.82