Skip to Content.
Sympa Menu

h5part - Re: [H5part] [Fwd: Small patch for H5Part with libhdf5-serial-1.8.4 on Debian]

h5part AT lists.psi.ch

Subject: H5Part development and discussion

List archive

Re: [H5part] [Fwd: Small patch for H5Part with libhdf5-serial-1.8.4 on Debian]


Chronological Thread 
  • From: Mark Howison <mark.howison AT gmail.com>
  • To: Achim Gsell <achim AT cybercity.ch>
  • Cc: willkomm AT sc.rwth-aachen.de, h5part AT lists.psi.ch
  • Subject: Re: [H5part] [Fwd: Small patch for H5Part with libhdf5-serial-1.8.4 on Debian]
  • Date: Wed, 21 Jul 2010 11:25:46 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=DYbXt7dXxmQi33URkaYVoPwDpRhLddyhhdSZEzMUf4QntmpYuUYEkO7GW5l81R+SBr BQX6+DZhc8pXmQIpfM7+7R5mcxyoaYl81pET6apc8lUoaRM2diqDwPsIaJnrnoFRJ7cI aGhpFr9O2jO69QBBgZo7BI41dSwOmb8fXkSJI=
  • List-archive: <https://lists.web.psi.ch/pipermail/h5part/>
  • List-id: H5Part development and discussion <h5part.lists.psi.ch>

Hi all,

I've merged the patch into the 1.6.2 branch. I'm working on a few bugs
in the Fortran interface with a user, and once those are finished I
will release 1.6.2, probably tomorrow.

Thanks,
Mark

On Wed, Jul 21, 2010 at 11:01 AM, Achim Gsell <achim AT cybercity.ch> wrote:
> Hi Johannes,
>
> thanks for the patch. For me it would be OK to make a version 1.6.2 with
> this patch applied. (@Mark: what do you think about it?)
>
> We are currently working on a new version with a completely new internal
> architecture. Nevertheless the H5Part and H5Block API will be (mostly)
> unchanged. The new version will require HDF5 1.8.x since we are using some
> of the new features. Actually I'm not sure whether it will be possible to
> use HDF5 1.8 with H5_USE_16_API for the new version. But we will see and
> keep this in mind. I don't see a show-stopper at the moment ...
>
> Achim
>
>>
>> From: Johannes Willkomm <willkomm AT sc.rwth-aachen.de>
>> Date: July 21, 2010 4:40:35 PM GMT+02:00
>> To: EWBethel AT lbl.gov
>> Subject: Small patch for H5Part with libhdf5-serial-1.8.4 on Debian
>>
>>
>> Hello,
>>
>> I have been using H5Part-1.4.0 for a long time, with both HDF5 1.6 and 1.8,
>> using H5_USE_16_API in the latter case.
>>
>> Now I have upgraded to 1.6.1 and I found that on Debian the compilation
>> fails
>> because of two errors in H5Part.c. The following patch solves it:
>>
>>
>> Index: src/H5Part.c
>> ===================================================================
>> --- src/H5Part.c        (Revision 2813)
>> +++ src/H5Part.c        (Arbeitskopie)
>> @@ -2293,7 +2293,11 @@
>>        data.pattern = pattern;
>>
>> #ifdef H5PART_HAVE_HDF5_18
>> -       hid_t child_id = H5Gopen( group_id, group_name, H5P_DEFAULT );
>> +       hid_t child_id = H5Gopen( group_id, group_name
>> +#ifndef H5_USE_16_API
>> +                                  , H5P_DEFAULT
>> +#endif
>> +                                  );
>>        if ( child_id < 0 ) return child_id;
>>        herr = H5Literate( child_id, H5_INDEX_NAME, H5_ITER_INC, 0,
>>                        _H5Part_iteration_operator2, &data );
>> @@ -2338,7 +2342,11 @@
>>        data.len = (size_t)len_obj_name;
>>
>> #ifdef H5PART_HAVE_HDF5_18
>> -       hid_t child_id = H5Gopen ( group_id, group_name, H5P_DEFAULT );
>> +       hid_t child_id = H5Gopen ( group_id, group_name
>> +#ifndef H5_USE_16_API
>> +                                  , H5P_DEFAULT
>> +#endif
>> +                                   );
>>        if ( child_id < 0 ) return child_id;
>>        herr = H5Literate ( child_id, H5_INDEX_NAME, H5_ITER_INC, 0,
>>                        _H5Part_iteration_operator2, &data );
>>
>>
>> The reason is that on Debian the HDF5 is configured to define
>> H5_USE_16_API to
>> one. So configure detects that it is HDF5 1.8, but still the 1.6 API is
>> used.
>>
>> With this patch it works on both Debian testing and another Linux system
>> where
>> I use a HDF5 1.8.2 compiled by myself, where USE_16 is not set.
>>
>> I use Debian testing and have these HDF5 versions installed.
>>
>> ii  libhdf5-serial-1.8.4                                 1.8.4-patch1-2
>> Hierarchical Data Format 5 (HDF5) - runtime files - serial version
>> ii  libhdf5-serial-dev                                   1.8.4-patch1-2
>> Hierarchical Data Format 5 (HDF5) - development files - serial version
>>
>> I also found version 1.6.0 to be broken, it compiled but it did not work
>> on my
>> Debian system.
>>
>> Best regards
>> Johannes
>>
>>
>>
>
> _______________________________________________
> H5Part mailing list
> H5Part AT lists.psi.ch
> https://lists.web.psi.ch/mailman/listinfo/h5part
>




Archive powered by MHonArc 2.6.19.

Top of Page