h5part AT lists.psi.ch
Subject: H5Part development and discussion
List archive
- From: John Biddiscombe <biddisco AT cscs.ch>
- To: Achim Gsell <achim.gsell AT psi.ch>, h5part AT lists.psi.ch
- Subject: Re: [H5part] Patch#1 : Win32 compiler support
- Date: Thu, 10 May 2007 10:31:37 +0200
- List-archive: <https://lists.web.psi.ch/pipermail/h5part/>
- List-id: H5Part development and discussion <h5part.lists.psi.ch>
OK, I will rename "_errno" to something like "_h5part_errno". But there is one place where we have to access the system "errno" to check whether the file already exists in the "H5PartOpen...() function.OK. If you remove _errno and use _h5errno instead then the only thing required should be
#ifndef WIN32
#include <unistd.h>
#else
#include <io.h>
#define open _open
#define close _close
#endif
this goes back in the private declarations
static h5part_int64_t _h5errno = H5PART_SUCCESS;
and then you just use _h5errno in place of the old _errno except the system errno which is ok to leave alone on windows.
by not using the varname _errno, all the issues go away.
I won't send a patch because I've already made some other changes which were supposed to be patch #2
JB
--
John Biddiscombe, email:biddisco @ cscs.ch
http://www.cscs.ch/about/BJohn.php
CSCS, Swiss National Supercomputing Centre | Tel: +41 (91) 610.82.07
Via Cantonale, 6928 Manno, Switzerland | Fax: +41 (91) 610.82.82
- [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/09/2007
- Re: [H5part] Patch#1 : Win32 compiler support, Achim Gsell, 05/09/2007
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Message not available
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Message not available
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Message not available
- Re: [H5part] Patch#2 : bux fix plus couple of additionsr, John Biddiscombe, 05/11/2007
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Message not available
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Re: [H5part] Patch#1 : Win32 compiler support, John Biddiscombe, 05/10/2007
- Re: [H5part] Patch#1 : Win32 compiler support, Achim Gsell, 05/09/2007
Archive powered by MHonArc 2.6.19.