opal AT lists.psi.ch

Subject: The OPAL Discussion Forum

List archive

[Opal] Undulator

From: "Adelmann Andreas (PSI)" <andreas.adelmann AT psi.ch>
To: "christof.j.kraus AT gmail.com" <christof.j.kraus AT gmail.com>
Cc: "Frey Matthias (PSI)" <matthias.frey AT psi.ch>, "opal AT lists.psi.ch" <Opal AT lists.psi.ch>
Subject: [Opal] Undulator
Date: Sun, 10 Mar 2019 12:48:40 +0000
Accept-language: en-US, de-CH
Authentication-results: localhost; dmarc=skipped

Hi Christof, I try to add an empty element Undulator (copy of Drift) and get the

following errors:

/gpfs/home/adelmann/opal/opal-2.0/src/Aperture/Split.cpp: In member function 'virtual Object* MSplit::clone(const string&)':

/gpfs/home/adelmann/opal/opal-2.0/src/Aperture/Split.cpp:761:33:
error:
invalid new-_expression_ of abstract class type 'MSplit'

     return new MSplit(name, this);

^

In file included from
/gpfs/home/adelmann/opal/opal-2.0/src/Aperture/Split.cpp:1:0:

/gpfs/home/adelmann/opal/opal-2.0/src/Aperture/Split.h:16:7:
note:
  because the following virtual functions are pure within 'MSplit':

 class 
MSplit: public DefaultVisitor, public Table {

       
^~~~~~

In file included from
/gpfs/home/adelmann/opal/opal-2.0/src/Classic/Algorithms/DefaultVisitor.h:24:0,

                 from
/gpfs/home/adelmann/opal/opal-2.0/src/Aperture/Split.h:5,

                 from
/gpfs/home/adelmann/opal/opal-2.0/src/Aperture/Split.cpp:1:

/gpfs/home/adelmann/opal/opal-2.0/src/Classic/AbsBeamline/BeamlineVisitor.h:135:18:
note:
virtual void BeamlineVisitor::visitUndulator(const Undulator&)

     virtual void
visitUndulator(const Undulator &) = 0;

Here the files I modified and added.

#
modified:   Algorithms/ParallelTTracker.cpp

#
modified:   Algorithms/ParallelTTracker.h

#
modified:   Classic/AbsBeamline/BeamlineVisitor.h

#
modified:   Classic/AbsBeamline/CMakeLists.txt

#
modified:   Classic/AbsBeamline/ElementBase.h

#
modified:   Classic/BeamlineCore/CMakeLists.txt

#
modified:   Elements/CMakeLists.txt

#
modified:   OpalConfigure/Configure.cpp

#

# Untracked files:

#   (use "git add <file>..." to include in what will be committed)

#

#
../doc/

#
Classic/AbsBeamline/Undulator.cpp

#
Classic/AbsBeamline/Undulator.h

#
Classic/BeamlineCore/UndulatorRep.cpp

#
Classic/BeamlineCore/UndulatorRep.h

#
Elements/OpalUndulator.cpp

#
Elements/OpalUndulator.h

Unfortunately I made all the changes on the master and not as intended

on the OPAL-FEL branch, however this is a minor issue :) .

Any idea what I miss with my commit?

Thanks Andreas

------
Dr. sc. math. Andreas (Andy) Adelmann
Head a.i. Labor for Scientific Computing and Modelling
Paul Scherrer Institut OHSA/D09 CH-5232 Villigen PSI
Phone Office: xx41 56 310 42 33 Fax: xx41 56 310 31 91
Phone Home: xx41 62 891 91 44
-------------------------------------------------------
Friday: ETH HPK G 28 +41 44 633 3076
============================================
The more exotic, the more abstract the knowledge,
the more profound will be its consequences.
Leon Lederman
============================================

[Opal] Undulator, Adelmann Andreas (PSI), 03/10/2019